Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raises InvalidSelectorException for invalid xpaths #9805

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

gpt14
Copy link
Contributor

@gpt14 gpt14 commented Sep 8, 2021

expected_conditions and wait modules raises InvalidSelectorException for invalid xpaths

Motivation and Context

Fixes issue #8813

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #9805 (b93067b) into trunk (fc05f3a) will increase coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head b93067b differs from pull request most recent head 787202a. Consider uploading reports for the commit 787202a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #9805      +/-   ##
==========================================
+ Coverage   44.48%   44.70%   +0.22%     
==========================================
  Files          83       83              
  Lines        5507     5529      +22     
  Branches      251      251              
==========================================
+ Hits         2450     2472      +22     
  Misses       2806     2806              
  Partials      251      251              
Impacted Files Coverage Δ
.../selenium/webdriver/support/expected_conditions.py 33.00% <100.00%> (+6.41%) ⬆️
py/selenium/webdriver/support/wait.py 36.53% <100.00%> (+5.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c8f20...787202a. Read the comment docs.

@AutomatedTester
Copy link
Member

thanks for the patch!

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 10bcce1 into SeleniumHQ:trunk Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants