Require "uri" in Selenium::Webdriver container module #9827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`URI` was gemified in Ruby 2.7 ruby/uri@a4a1d4c and therefore must be manually required to use. Fixes SeleniumHQ#9825
|
|
|
Wow, you put a lot of work into a 2 word PR. Really appreciate the contribution, and sorry it took so long for me to see it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds one line to
rb/lib/selenium/webdriver.rb:Fixes #9825
Motivation and Context
URIwas gemified in Ruby 2.7 ruby/uri@a4a1d4c and therefore must be manually required to use. I opened issue #9825 illustrating the problem I was running into.NB: I was not sure how to add tests for this, as this was a bugfix that made the library work correctly.
Types of changes
Checklist