Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] Consider max-session value while selecting the slot and identifying Node capacity #9838

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

pujagani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Consider max-session value while selecting the slot and identifying Node capacity

Motivation and Context

Node allows configuring max-session value. In the current implementation, to ensure Grid is not underutilized, multiple threads are used to reserve a slot and create the session. As a result, multiple sessions are created simultaneously which often exceeds the max-session value and disregards it. To avoid overloading the machine, it is crucial that the max-session value is considered. The changes fix this by checking for that the current number of sessions do not exceed the max-session value during slot selection.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shs96c
Copy link
Member

shs96c commented Sep 20, 2021

Looks great. Thank you, @pujagani!

@shs96c shs96c merged commit 46fc208 into SeleniumHQ:trunk Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants