Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Fix type hint on chrome option method #9840

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

fergushev
Copy link
Contributor

Description

This is a followup fix to @AutomatedTester's fix (95707f2) which adds string lists to the type hint. Quick code example to repro the bug/fix:

from selenium import webdriver

options = webdriver.ChromeOptions()
options.add_experimental_option("excludeSwitches", ["enable-automation"])

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2021

CLA assistant check
All committers have signed the CLA.

@AutomatedTester
Copy link
Member

Thank you for the patch!

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #9840 (e7111d6) into trunk (e703235) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #9840   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files          83       83           
  Lines        5501     5501           
  Branches      249      249           
=======================================
  Hits         2448     2448           
  Misses       2804     2804           
  Partials      249      249           
Impacted Files Coverage Δ
py/selenium/webdriver/chromium/options.py 53.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41dfb46...e7111d6. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester AutomatedTester merged commit 2c071c8 into SeleniumHQ:trunk Sep 20, 2021
@fergushev fergushev deleted the list-type-hint-py branch September 20, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants