-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb]: Standardise driver logging output #9850
[rb]: Standardise driver logging output #9850
Conversation
Failure seems unrelated
Not really sure what happened here, guessing there is a secondary blank 0x0 image somewhere on the page it's finding? |
This isn't a backward compatible change and the code isn't marked as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite follow what do we standard against. Do you want the browser logs to look like Ruby's Logger
class?
@@ -22,22 +22,22 @@ module WebDriver | |||
class LogEntry | |||
attr_reader :level, :timestamp, :message | |||
|
|||
def initialize(level, timestamp, message) | |||
@level = level | |||
def initialize(timestamp, level, message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any value to change the order here? Even though nobody should be initializing this class directly, I don't believe it's worth breaking backwards compatibility without a good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll undo this change, but it was only used in the entire codebase in one location, which was api private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry yes. The other logger formats in a different way, and the timestamp is always first in most loggers. Here it wasn't.
Kudos, SonarCloud Quality Gate passed! |
Is this RtM now @p0deje (The ruby failure seems to find a 0x0 reference). |
@luke-hill Could you please reply to #9850 (review)? |
Ensure all log formats (Including browser ones), are in a consistent format
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Alter logging to conform to other standard log formats
Motivation and Context
Types of changes
Checklist