Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commands to be loaded via the ServiceLoader #9854

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Sep 20, 2021

Description

When adding commands via the Augmenter, it is sometimes helpful to
provide an actual command too. This change allows drivers to specify
new commands and add them as necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When adding commands via the Augmenter, it is sometimes helpful to
provide an actual command too. This change allows drivers to specify
new commands and add them as necessary.
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shs96c shs96c merged commit 15dfc62 into SeleniumHQ:trunk Sep 20, 2021
@shs96c shs96c deleted the extension-commands branch September 20, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant