Create interfaces for RemoteWebDriver to use with Augmenter #9856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
force-pushed
the
java_add_augmented
branch
from
2fda026 to
37a3b75
Compare
titusfortner
changed the title
titusfortner
force-pushed
the
java_add_augmented
branch
8 times, most recently
from
c0bee02 to
d706012
Compare
shs96c
requested changes
Sep 23, 2021
java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
Outdated
Show resolved
Hide resolved
java/src/org/openqa/selenium/chromium/AddHasNetworkConditions.java
Outdated
Show resolved
Hide resolved
java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java
Outdated
Show resolved
Hide resolved
java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java
Outdated
Show resolved
Hide resolved
java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java
Outdated
Show resolved
Hide resolved
titusfortner
added a commit
to titusfortner/selenium
that referenced
this pull request
Sep 23, 2021
|
I marked all the conversations as resolved for the things I fixed in the most recent commit. These others seem slightly more involved, but I'll see what I can make of them tonight so we can discuss tomorrow. |
…Driver via Augmenter
…teWebDriver via Augmenter
… have the same conventions. Complete JavaDocs in interface, ImmutableMap.of for all maps, Require.nonNull in all interface implementations, etc
titusfortner
force-pushed
the
java_add_augmented
branch
from
df133e9 to
2ace4ca
Compare
|
SonarCloud Quality Gate failed. |
shs96c
approved these changes
Sep 28, 2021
| @Override | ||
| public HasCasting getImplementation(Capabilities capabilities, ExecuteMethod executeMethod) { | ||
| return new HasCasting() { | ||
| @Override public List<Map<String, String>> getCastSinks() { |
There was a problem hiding this comment.
Style nit: put the @Override on its own line. What you've got here compiles, but it's not the style we follow on the project.
|
|
||
|
|
||
| private static final Map<String, CommandInfo> COMMANDS = ImmutableMap.of( | ||
| GET_NETWORK_CONDITIONS, new CommandInfo("/session/:sessionId/chromium/network_conditions",HttpMethod.GET), |
There was a problem hiding this comment.
Nit: a space after the , -> ", HttpMethod.GET)
| * @param parameters any information needed to execute the Dev Tools command. | ||
| * @return the name and value of the response. | ||
| */ | ||
| public Map<String, Object> executeCdpCommand(String commandName, Map<String, Object> parameters); |
There was a problem hiding this comment.
Nit: Methods on interfaces are public by default.
This was referenced Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what we did for the Firefox capabilities, but I'm implementing, but I'm not sure this is the best way to do this (i.e. with the
ChromiumNetworkConditionsclass). Would be a lot simpler to do ordered parameters, but this lets users only specify the things they care about.Edit: I'm just going to add everything here to get feedback on it all.