[js] Allow builder to set a single arbitrary capability

[pujagani]

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Allow builder to set a single arbitrary capability. Fixes #9830.

Motivation and Context

Details are explained in #9830

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[titusfortner]

I think setCapability() is the "right" method name, but might be worth considering using withCapabilities() since that sounds like it is the backward compatible name.

Also, can additional capabilities can be added to the browser options class like it can be in the other languages? Makes sense to have it in both places.

[pujagani]

I think setCapability() is the "right" method name, but might be worth considering using withCapabilities() since that sounds like it is the backward compatible name.

@AutomatedTester You might have more context regarding this since it was deprecated for a reason. Can you please help answer this one? Thank you!

Also, can additional capabilities can be added to the browser options class like it can be in the other languages? Makes sense to have it in both places.

Yes, this is possible since the Options class inherits from Capabilities. So it is possible to set a capability using Options as with other languages.

[AutomatedTester]

@titusfortner has been looking at these in all the different bindings, maybe he can leave his thoughts.

[titusfortner]

My take is that as long as there's a setCapability() in the options class that works to set top level capabilities, then we should restore withCapabilities() for this functionality the builder. It's not the same method name as Java's builder class, but I think maintaining backwards compatibility would be more useful here.

[pujagani]

I agree with @titusfortner. I will restore withCapabilities in a separate PR to ensure backward compatibility. But since other language bindings have a setCapability() in the builder, I might be a good idea to have both.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information