Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add w3c capabilities to Python options #9870

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

titusfortner
Copy link
Member

This creates setters and getters in the options classes for all w3c compliant standard capabilities. Type hints, docstrings and links to the spec have been added to each method.

@codecov-commenter
Copy link

Codecov Report

Merging #9870 (e65f070) into trunk (10bcce1) will increase coverage by 0.25%.
The diff coverage is 78.57%.

❗ Current head e65f070 differs from pull request most recent head 9efcd57. Consider uploading reports for the commit 9efcd57 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #9870      +/-   ##
==========================================
+ Coverage   44.70%   44.96%   +0.25%     
==========================================
  Files          83       83              
  Lines        5529     5531       +2     
  Branches      251      251              
==========================================
+ Hits         2472     2487      +15     
+ Misses       2806     2793      -13     
  Partials      251      251              
Impacted Files Coverage Δ
py/selenium/webdriver/chromium/options.py 52.17% <ø> (-1.78%) ⬇️
py/selenium/webdriver/firefox/options.py 42.85% <ø> (-3.81%) ⬇️
py/selenium/webdriver/opera/options.py 28.57% <ø> (+2.04%) ⬆️
py/selenium/webdriver/safari/options.py 36.36% <ø> (-10.31%) ⬇️
py/selenium/webdriver/webkitgtk/options.py 40.00% <ø> (+4.86%) ⬆️
py/selenium/webdriver/common/options.py 60.63% <78.57%> (+26.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88bb08...9efcd57. Read the comment docs.

@AutomatedTester AutomatedTester merged commit 2835393 into SeleniumHQ:trunk Sep 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@titusfortner titusfortner deleted the py_opts branch December 4, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants