[java] use FileDetector to install Firefox addons #9872

titusfortner · 2021-09-28T16:01:35Z

I don't see an ideal way to do this.

The whole point is to be able to do this with the Augmenter, which means the interfaces which don't know about RemoteWebDriver methods, and I don't want to put the driver instance as a parameter for the method in the interface.

~~This is the best I came up with.:~~

~~The implementation is mostly copied from RemoteWebElement#upload but again, I don't see an easy way to put this logic where both of them can access it.~~

Edit:
I changed this so it tries the string as provided first, and if that doesn't work, it determines if the file exists locally, and if so uploads it and retries.

Not sure it's ideal either, but it won't break anything, and won't keep us from doing something better later.

shs96c · 2021-09-28T16:22:18Z

java/src/org/openqa/selenium/firefox/FirefoxDriver.java

@@ -269,6 +269,13 @@ public String installExtension(Path path) {
    return extensions.installExtension(path);
  }

+  @Override
+  public String installExtension(Path path, FileDetector detector) {


Users really shouldn't need to know about the presence of the file detector.

shs96c · 2021-09-29T13:06:01Z

java/src/org/openqa/selenium/firefox/AddHasExtensions.java

+            INSTALL_EXTENSION,
+            ImmutableMap.of("path", path.toAbsolutePath().toString(), "temporary", false));
+        } catch (WebDriverException ex) {
+          File localFile = new LocalFileDetector().getLocalFile(path.toString());


The more correct thing to do would be to make RemoteExecuteMethod implement WrapsDriver. You could then get the driver, check if it's remote, and then get the file detector that way. Relying on exceptions for flow control is generally frowned upon.