Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Update test_remote_webdriver.py to use file_names #1568 #1580

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

rdinoff
Copy link
Contributor

@rdinoff rdinoff commented Feb 19, 2024

files does not get returned in a consistent order from get_downloadable_files() which is why the sort is needed in the assert. Use file_names instead

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 46b02f5
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/65d5dff557b6050008b39c11
😎 Deploy Preview https://deploy-preview-1580--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

files does not get returned in a consistent order from get_downloadable_files() which is why the sort is needed in the assert.  Use file_names instead
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rdinoff!

@diemol diemol merged commit 97b9181 into SeleniumHQ:trunk Feb 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants