-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate and update ruby code examples with internet explorer #1748
Migrate and update ruby code examples with internet explorer #1748
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aguspe !
PR Review 🔍
|
PR Code Suggestions ✨
|
@harsha509 I saw some window tests failing should I skip the IE examples I added? It's a bit difficult for me locally to test IE due to my computer being a mac |
we need to execute tests in chromium edge (IE in edge mode), can you try setting this option |
Perfect, I will do it tomorrow and update the whole PR |
…o update_ruby_examples_for_ie
@harsha509 the whole PR is updated, I hope that does the trick :) |
I can see that the following 2 tests are failing on windows:
|
Hi @harsha509 I hope you are doing well, I updated the 2 tests that were failing and hopefully the pipeline will be green this time |
Hi @harsha509 I re-merged the trunk, so I hope the tests are ready to run again, after this I will continue updating the ruby docs, thank you so much! |
Hi @harsha509 I looked more into it and I found that the ruby library does not support the silent option so I added it on this PR as it is on other bindings such as java and js, once the PR is merged, the test will stop failing: |
The PR adding support for the silent capability has been merged SeleniumHQ/selenium#14152, so for now I will skip the silent test until the release of selenium 4.22.0, so everything should work now @harsha509 |
…deploy site] * Migrate code to examples * Finish code migration * Refactor code migration * Update examples * Update silent options * Update silent options --------- Co-authored-by: aguspe <[email protected]> Co-authored-by: Sri Harsha <[email protected]> 69a9183
User description
Description
This PR migrates and adds code examples using ruby for IE
Motivation and Context
It's important to keep the examples and documentation up to date to facilitate usage by all the users
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Changes walkthrough 📝
internet_explorer_spec.rb
Add comprehensive test cases for Internet Explorer options in Ruby.
examples/ruby/spec/browsers/internet_explorer_spec.rb
settings, and protected mode settings.
internet_explorer.en.md
Update Ruby code examples in Internet Explorer documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.en.md
internet_explorer.ja.md
Update Ruby code examples in Japanese Internet Explorer documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.ja.md
internet_explorer.pt-br.md
Update Ruby code examples in Portuguese Internet Explorer
documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.pt-br.md
internet_explorer.zh-cn.md
Update Ruby code examples in Chinese Internet Explorer documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.zh-cn.md