Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed hanging badge code #1912

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

shbenzer
Copy link
Contributor

@shbenzer shbenzer commented Aug 29, 2024

User description

A badge code was left hanging after the python example in using_selenium.md > Executing

Description

removed leftover badge code in using_selenium.md > Executing for all translations

Motivation and Context

cleaning up documentation

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Removed leftover badge code from the Python example section in the "Using Selenium" documentation.
  • Changes applied to all translations: English, Japanese, Portuguese, and Chinese.

Changes walkthrough 📝

Relevant files
Documentation
using_selenium.en.md
Remove hanging badge code from English documentation         

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md

  • Removed leftover badge code from Python example.
+0/-1     
using_selenium.ja.md
Remove hanging badge code from Japanese documentation       

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md

  • Removed leftover badge code from Python example.
+0/-1     
using_selenium.pt-br.md
Remove hanging badge code from Portuguese documentation   

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.pt-br.md

  • Removed leftover badge code from Python example.
+0/-1     
using_selenium.zh-cn.md
Remove hanging badge code from Chinese documentation         

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.zh-cn.md

  • Removed leftover badge code from Python example.
+0/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

netlify bot commented Aug 29, 2024

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 58406e5

@qodo-merge-pro qodo-merge-pro bot added the documentation Improvements or additions to documentation label Aug 29, 2024
Copy link
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shbenzer !

@harsha509 harsha509 merged commit d501255 into SeleniumHQ:trunk Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Review effort [1-5]: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants