SAI-34 [CoreService] Implement the API endpoint for Speech-to-Text #24
Conversation
hphun9
commented
Aug 19, 2023
hphun9
commented
- Implement endpoint /transcribe to translate audio speech-to-text
hphun9
requested review from
BinhPhamQuang,
minhnld and
tritct
and removed request for
BinhPhamQuang,
minhnld and
tritct
| GOOGLE_CREDENTIAL_FILE: ${{ secrets.GOOGLE_CREDENTIAL_FILE }} | ||
| GOOGLE_PROJECT_ID: ${{ secrets.GOOGLE_PROJECT_ID }} |
There was a problem hiding this comment.
Did you test this,
Do you have permission to add these secrets? I don't remember granting you those
There was a problem hiding this comment.
Actually, I've just testing from local. I don't have any permission to add these secrets. So, Can you grant permission for me then i can test it?
| detail="We have an error uploading files", | ||
| ) | ||
|
|
||
| speech_to_text = Speech2Text(gcp_credentials) |
There was a problem hiding this comment.
This is not how dependency injection works, do you understand how it works?
There was a problem hiding this comment.
As far as I know, dependency injection is the pattern that class A using some method of class B and those methods is called dependency. I try to use this like some api you wrote before. I feel a little bit strange when i code it. Can you give me some recommend?
| config = cloud_speech.RecognitionConfig( | ||
| auto_decoding_config=cloud_speech.AutoDetectDecodingConfig(), | ||
| language_codes=[language_code], | ||
| model="long", | ||
| # Reference: https://cloud.google.com/speech-to-text/v2/docs/transcription-model | ||
| features=cloud_speech.RecognitionFeatures( | ||
| enable_automatic_punctuation=True, | ||
| ), | ||
| ) | ||
|
|
There was a problem hiding this comment.
This config should be a global variable or can be injected somewhere,
But I just got the feeling that you just copied this code from an example without changing it to adapt to the codebase convention and tech stack, didn't you?
There was a problem hiding this comment.
I'm not got you mind. But I will inject this configuration instead of using like this.
| recogniser_gcp = f"projects/{project_id}/locations/global/recognizers/_".format( | ||
| project_id=project_id | ||
| ) |
There was a problem hiding this comment.
This should be a constant to be reused not recomputed every time this function was called, like I said you have to understand the code you wrote to see any abnormal about it...
