Skip to content

Commit

Permalink
LibWeb: Do not break WebDriver errors into multiple socket writes
Browse files Browse the repository at this point in the history
Very similar to commit e5877cda61eb53cd9c1eebbfaf3c35d084b2973c.

By sending as much data as we can in a single write, we see a massive
performance improvement on WPT tests that hammer WebDriver with errors.

On my Linux machine, this reduces the runtime of:
    /webdriver/tests/classic/perform_actions/invalid.py
from 45-60s down to 3-4s.

(cherry picked from commit 7a15e3ee5caa9332f3f6011cc21058e6ceab838c)
  • Loading branch information
trflynn89 authored and nico committed Nov 15, 2024
1 parent ed67435 commit 9e773e4
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions Userland/Libraries/LibWeb/WebDriver/Client.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -330,18 +330,17 @@ ErrorOr<void, Client::WrappedError> Client::send_error_response(Error const& err
JsonObject result;
result.set("value", move(error_response));

StringBuilder content_builder;
result.serialize(content_builder);

StringBuilder header_builder;
header_builder.appendff("HTTP/1.1 {} {}\r\n", error.http_status, reason);
header_builder.append("Cache-Control: no-cache\r\n"sv);
header_builder.append("Content-Type: application/json; charset=utf-8\r\n"sv);
header_builder.appendff("Content-Length: {}\r\n", content_builder.length());
header_builder.append("\r\n"sv);

TRY(m_socket->write_until_depleted(TRY(header_builder.to_byte_buffer())));
TRY(m_socket->write_until_depleted(TRY(content_builder.to_byte_buffer())));
auto content = result.serialized<StringBuilder>();

StringBuilder builder;
builder.appendff("HTTP/1.1 {} {}\r\n", error.http_status, reason);
builder.append("Cache-Control: no-cache\r\n"sv);
builder.append("Content-Type: application/json; charset=utf-8\r\n"sv);
builder.appendff("Content-Length: {}\r\n", content.length());
builder.append("\r\n"sv);
builder.append(content);

TRY(m_socket->write_until_depleted(builder.string_view()));

log_response(error.http_status);
return {};
Expand Down

0 comments on commit 9e773e4

Please sign in to comment.