-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFI Prekernel (3/N): Kernel/EFI: Add EFI service and protocol headers #24985
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I still have a review pending, weird
7374033
to
516bbb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks harmless enough :)
516bbb7
to
54ace82
Compare
54ace82
to
574d377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just two (types) of followup question.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
These definitions are adapted from the UEFI spec to match our code style.
574d377
to
1538538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for CI one last time. (Let's see if I need to rebase this manually, GitHub claims that I do.)
These headers will be used by the EFI Prekernel to communicate with the platform firmware.
The definitions are adapted from the UEFI specification to match our code style.
This PR does not depend on any of the other EFI Prekernel PRs.