Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 EPS05 code fix should fix implementations and callers #126

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sharwell
Copy link
Contributor

@sharwell sharwell commented Apr 8, 2019

Fixes #122
Fixes #123

using System.Diagnostics;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone needs to apply StyleCop analysers 😉
...or configure VS
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the solution is missing a .editorconfig. I'll get it cleaned up.

@sharwell sharwell changed the title EPS05 code fix should fix implementations and callers 🚧 EPS05 code fix should fix implementations and callers Apr 9, 2019
@sharwell
Copy link
Contributor Author

sharwell commented Apr 9, 2019

@SergeyTeplyakov I need to fix a few issues with this feature before it is merged. My local update shares code with #136 so I will wait until that one is merged.

@sharwell sharwell marked this pull request as draft April 17, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants