Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spectral-metric #102

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

lindsaydbrin
Copy link
Contributor

Description:

Remove spectral-metric and related code, as it's not being used in the app.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@lindsaydbrin lindsaydbrin marked this pull request as draft June 3, 2022 15:00
@lindsaydbrin lindsaydbrin force-pushed the hotfix/remove_spectral_clustering branch from 80e3873 to 457e67c Compare June 3, 2022 15:02
@lindsaydbrin lindsaydbrin marked this pull request as ready for review June 3, 2022 15:02
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lindsaydbrin lindsaydbrin enabled auto-merge (squash) June 3, 2022 15:19
@lindsaydbrin lindsaydbrin merged commit 67436de into main Jun 3, 2022
@lindsaydbrin lindsaydbrin deleted the hotfix/remove_spectral_clustering branch June 3, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants