Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected borders in Performance Analysis table #118

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented Jun 6, 2022

Description:

Fixes #90

  • Fix unexpected borders in Table as Table sx={{...}} was overwriting the sx defined inside Table.
    • This also includes the bold headers dans removing the border around the whole table.
    • Before
      Screen Shot 2022-06-06 at 1 10 06 PM
    • After
      Screen Shot 2022-06-06 at 1 09 50 PM
  • Clean up
    • Select only classes below & prevent styling from "bleeding" out of the component and into other components with the same class names.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

as `Table sx={{...}}` was overwriting the `sx` defined inside `Table`.
Select only classes below `&` prevent styling from "bleeding" out of the component and into other components with the same class names.
@JosephMarinier JosephMarinier enabled auto-merge (squash) June 6, 2022 17:20
@JosephMarinier JosephMarinier merged commit 3ba4a6b into main Jun 6, 2022
@JosephMarinier JosephMarinier deleted the hotfix/dashboard-table-border branch June 6, 2022 17:28
gabegma pushed a commit that referenced this pull request Jun 16, 2022
* Fix unexpected borders in Table as `Table sx={{...}}` was overwriting the `sx` defined inside `Table`.
* Clean up
  - Select only classes below `&` prevent styling from "bleeding" out of the component and into other components with the same class names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Table styling - Remove black border from headers
2 participants