Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for performance analysis comparison table #420

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Test for performance analysis comparison table #420

merged 6 commits into from
Feb 24, 2023

Conversation

nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Feb 2, 2023 •
edited
Loading

Resolve #

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn nandhinibsn self-assigned this Feb 2, 2023
@nandhinibsn nandhinibsn force-pushed the nandhini/test-performance-analysis-comparison-table branch from babe44a to 0d639ee Compare February 16, 2023 15:16
@nandhinibsn nandhinibsn force-pushed the nandhini/test-performance-analysis-comparison-table branch from 0d639ee to 13b8341 Compare February 23, 2023 01:14
JosephMarinier
JosephMarinier approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nandhinibsn
Copy link
Contributor Author

Thank you @JosephMarinier for your time and valuable suggestions :)

@nandhinibsn nandhinibsn merged commit fb6bf4e into main Feb 24, 2023
@nandhinibsn nandhinibsn deleted the nandhini/test-performance-analysis-comparison-table branch February 24, 2023 22:29
JosephMarinier added a commit that referenced this pull request Feb 25, 2023
@JosephMarinier
Fix front-end tests
940b9cd 
The problem was caused by #420 and #466 having incompatible changes (but yet no conflicts).
@JosephMarinier JosephMarinier mentioned this pull request Feb 25, 2023
Merged
4 tasks
JosephMarinier added a commit that referenced this pull request Feb 27, 2023
@JosephMarinier
Fix front-end tests (#468)
a92d7dc 
The problem was caused by #420 and #466 having incompatible changes (but yet no conflicts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosephMarinier JosephMarinier JosephMarinier approved these changes

Assignees

@nandhinibsn nandhinibsn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandhinibsn @JosephMarinier