Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish switches 🇵🇱 #84

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Polish switches 🇵🇱 #84

merged 2 commits into from
Jun 3, 2022

Conversation

JosephMarinier
Copy link
Contributor

@JosephMarinier JosephMarinier commented May 31, 2022

Description:

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Copy link
Contributor

@nandhinibsn nandhinibsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we change this to checkbox because of the color suggestion for toggle thing?

@JosephMarinier
Copy link
Contributor Author

JosephMarinier commented Jun 2, 2022

@nandhinibsn As I said in the commit message

Change config switches to checkboxes in accordance with this article: https://uxplanet.org/checkbox-vs-toggle-switch-7fc6e83f10b8

@JosephMarinier JosephMarinier merged commit c6defba into main Jun 3, 2022
@JosephMarinier JosephMarinier deleted the joseph/switches branch June 3, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants