Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#87 Fix issue where data actions would not work #98

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

Dref360
Copy link
Contributor

@Dref360 Dref360 commented Jun 2, 2022

Description:

Fixes #87

We were supplying NO_DATA_ACTIONS to the route, we now filter it out as it is only used during filtering.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@Dref360 Dref360 requested a review from gabegma June 2, 2022 13:34
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - were you able to test that it fixes the issue?

@Dref360
Copy link
Contributor Author

Dref360 commented Jun 2, 2022

Added tests and I tested manually as well.

@Dref360 Dref360 closed this Jun 2, 2022
@Dref360 Dref360 reopened this Jun 2, 2022
@Dref360 Dref360 enabled auto-merge (squash) June 2, 2022 19:51
@Dref360 Dref360 merged commit aad15c0 into main Jun 2, 2022
@Dref360 Dref360 deleted the hotfix/87_actions branch June 2, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with adding a proposed action
2 participants