SimpleDateFormat is not thread safe so we should create a new instanc…

…e every time.
SevenSpikes · Nov 2, 2017 · 0ac0a6b · 0ac0a6b
1 parent 1d83731
commit 0ac0a6b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 32 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.storakle.shopify</groupId>
     <artifactId>shopify-api-java-wrapper</artifactId>
-    <version>0.2.10</version>
+    <version>0.2.11</version>
     <build>
         <sourceDirectory>src/main/java</sourceDirectory>
         <plugins>

diff --git a/src/main/java/com/storakle/shopify/jackson/FlexDateDeserializer.java b/src/main/java/com/storakle/shopify/jackson/FlexDateDeserializer.java
@@ -21,30 +21,17 @@ public final class FlexDateDeserializer extends JsonDeserializer<Date>
     @Override
     public Date deserialize(final JsonParser parser, final DeserializationContext context) throws IOException
     {
+        SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssX");
+
         final String date = parser.getText();
         try
         {
-            return getFormatter().parse(date);
+            return formatter.parse(date);
         }
         catch (final ParseException ex)
         {
             // Not worked, so let the default date serializer give it a try.
             return DateDeserializer.instance.deserialize(parser, context);
         }
     }
-
-    //
-    //
-    private static SimpleDateFormat getFormatter()
-    {
-        return FormatHolder.INSTANCE;
-    }
-
-    /**
-     */
-    private interface FormatHolder
-    {
-        SimpleDateFormat INSTANCE = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssX");
-    }
-
 }
diff --git a/src/main/java/com/storakle/shopify/jackson/FlexDateSerializer.java b/src/main/java/com/storakle/shopify/jackson/FlexDateSerializer.java
@@ -18,20 +18,7 @@ public final class FlexDateSerializer extends JsonSerializer<Date>
     @Override
     public void serialize(final Date value, final JsonGenerator gen, final SerializerProvider arg2) throws IOException
     {
-        gen.writeString(getFormatter().format(value));
-    }
-
-    //
-    //
-    private static SimpleDateFormat getFormatter()
-    {
-        return FormatHolder.INSTANCE;
-    }
-
-    /**
-     */
-    private interface FormatHolder
-    {
-        SimpleDateFormat INSTANCE = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssX");
+        SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssX");
+        gen.writeString(formatter.format(value));
     }
 }