Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burner wallet added #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

burner wallet added #389

wants to merge 1 commit into from

Conversation

ajinkyaa
Copy link

No description provided.

youngkidwarrior
youngkidwarrior requested changes Sep 12, 2021
View reviewed changes
Copy link
Member

@youngkidwarrior youngkidwarrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call useBurner() inside the body of the context, right below useWalletConnect()

const burner = useBurner()

Then return burner from the context by putting it in the value object of the Provider

packages/app/src/contexts/Web3Context/Web3Context.tsx
@@ -5,6 +5,7 @@ import AsyncStorage from '@react-native-community/async-storage';
import { useWalletConnect } from '@walletconnect/react-native-dapp';
import { IConnector } from '@walletconnect/types';
import { INFURA_ID } from 'react-native-dotenv';
import { useBurner } from '../../hooks/Burner';

type Web3ContextType = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the type of the burner wallet

packages/app/src/contexts/Web3Context/Web3Context.tsx Outdated
@@ -40,6 +41,7 @@ export const Web3ContextProvider: React.FC = ({ children }) => {
} else {
await connector.killSession();
await connectDID(connector, wallet);
await useBurner();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not giving us back the burner wallet. We need to return the burner wallet from the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngkidwarrior youngkidwarrior youngkidwarrior requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajinkyaa @youngkidwarrior