Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Rename Directories: proprietary_model->api_inference, oss_model->local_inference for Better Clarity #859

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

HuanzhiMao
Copy link
Collaborator

@HuanzhiMao HuanzhiMao commented Dec 30, 2024

Address #856

The folder names oss_model and proprietary_model within the model_handler directory are updated to better reflect their actual purpose.
The current naming is misleading, as there are open-source model handlers located in the proprietary_model folder, which causes confusion. Updating these names will improve clarity and maintain logical organization.

Copy link
Collaborator

@CharlieJCJ CharlieJCJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@HuanzhiMao HuanzhiMao merged commit 5fe4a87 into ShishirPatil:main Jan 3, 2025
@HuanzhiMao HuanzhiMao deleted the model-classification branch January 3, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-General General BFCL Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BFCL] Rename Misleading oss_model and proprietary_model Folders in model_handler Directory
2 participants