-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fable 4 update (WIP) #15
Open
PaigeM89
wants to merge
10
commits into
Shmew:master
Choose a base branch
from
PaigeM89:fable-4-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaigeM89
commented
Nov 12, 2023
@@ -403,9 +407,14 @@ let main = React.memo(fun () -> | |||
] | |||
]) | |||
|
|||
let render' = React.memo(fun () -> | |||
[<ReactComponent>] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR I'll update all the components to use this for function components
@Shmew - are you still working on this library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
fake build
or.\build.cmd
) on local branch was successfulPull request type
Please check the type of change your PR introduces:
What is the current behavior?
This project cannot be used on Fable 4 projects.
What is the new behavior?
I wasn't able to split this into smaller pieces; updating to Fable 4 wasn't too bad, but verifying the rest of the build was a bit of work just to make sure the changes were stable.
This PR changes a few things:
Fable.Extras
has been removed, as that library is using Fable 3Minor changes:
Does this introduce a breaking change?
Existing applications should upgrade to Fable 4 if possible.
Other information
I did not thoroughly test the bridge components.
Let me know what additional changes you'd like to see before we merge this - I'd really like to use it!