Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-weebify actors #1162

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: de-weebify actors #1162

merged 1 commit into from
Dec 30, 2024

Conversation

revam
Copy link
Member

@revam revam commented Dec 30, 2024

No description provided.

@revam revam enabled auto-merge (squash) December 30, 2024 01:31
@revam revam disabled auto-merge December 30, 2024 01:31
@revam revam force-pushed the fix-de-weebify-actors branch 2 times, most recently from ad6e949 to 678bf93 Compare December 30, 2024 01:34
@revam revam force-pushed the fix-de-weebify-actors branch from 678bf93 to 61288c9 Compare December 30, 2024 01:36
@revam revam enabled auto-merge (squash) December 30, 2024 01:36
@revam revam merged commit 792ea8c into master Dec 30, 2024
2 checks passed
@revam revam deleted the fix-de-weebify-actors branch December 30, 2024 01:37
@da3dsoul
Copy link
Member

Why

@revam
Copy link
Member Author

revam commented Dec 30, 2024

I can revert it for the UI part, but the server side role value changed, so the web UI needed to be updated accordingly.

And if you're wondering why I did three forced pushes, then it's because initially I was going to go full no backwards compatibility with stable, then I later changed my mind to try and be compatible with both stable and daily, but then I remembered @harshithmohan had said the web UI was currently in a state where it was fine to break compatibility with stable, so I tried to reverse the changes to make it compatible with stable, failed miserably, and had to fix the changes. And by the last commit the code was the same as the initial commit again.

@da3dsoul
Copy link
Member

No, I was wondering why you renamed it in general

@revam
Copy link
Member Author

revam commented Dec 30, 2024

2-3am coding session train-of-thought thought it was better to call the actors as Actor(s) (proper English word) instead of Seiyuu(s) (weeb-ish engrish word).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants