-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cli hydrogen on 3.69 #4772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -58,5 +58,4 @@ export declare const reportingRateLimit: {
timeout: {
days: number;
};
-};
-export declare const themeKitAccessDomain: string;
\ No newline at end of file
+};
\ No newline at end of file
packages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.69.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.69.3";
\ No newline at end of file
packages/cli-kit/dist/private/node/api/graphql.d.ts@@ -1,5 +1,5 @@
-import { Variables } from 'graphql-request';
-export declare function debugLogRequestInfo(api: string, query: string, url: string, variables?: Variables, headers?: {
+import { RequestDocument, Variables } from 'graphql-request';
+export declare function debugLogRequestInfo(api: string, query: RequestDocument, variables?: Variables, headers?: {
[key: string]: string;
}): void;
export declare function errorHandler(api: string): (error: unknown, requestId?: string) => unknown;
\ No newline at end of file
packages/cli-kit/dist/private/node/api/rest.d.ts@@ -1,8 +1,9 @@
+/// <reference types="node" resolution-mode="require"/>
import { AdminSession } from '@shopify/cli-kit/node/session';
export declare function restRequestBody<T>(requestBody?: T): string | undefined;
export declare function restRequestUrl(session: AdminSession, apiVersion: string, path: string, searchParams?: {
[name: string]: string;
-}): string;
+}, env?: NodeJS.ProcessEnv): string;
export declare function restRequestHeaders(session: AdminSession): {
[key: string]: string;
};
packages/cli-kit/dist/public/node/api/admin.d.ts@@ -34,10 +34,9 @@ export declare function supportedApiVersions(session: AdminSession): Promise<str
*
* @param store - Store FQDN.
* @param version - API version.
- * @param session - User session.
* @returns - Admin API URL.
*/
-export declare function adminUrl(store: string, version: string | undefined, session?: AdminSession): string;
+export declare function adminUrl(store: string, version: string | undefined): string;
/**
* Executes a REST request against the Admin API.
*
packages/cli-kit/dist/public/node/themes/api.d.ts@@ -9,6 +9,14 @@ export declare function fetchThemeAsset(id: number, key: Key, session: AdminSess
export declare function deleteThemeAsset(id: number, key: Key, session: AdminSession): Promise<boolean>;
export declare function bulkUploadThemeAssets(id: number, assets: AssetParams[], session: AdminSession): Promise<Result[]>;
export declare function fetchChecksums(id: number, session: AdminSession): Promise<Checksum[]>;
-export declare function themeUpdate(id: number, params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
-export declare function themePublish(id: number, session: AdminSession): Promise<Theme | undefined>;
-export declare function themeDelete(id: number, session: AdminSession): Promise<boolean | undefined>;
\ No newline at end of file
+interface UpgradeThemeOptions {
+ fromTheme: number;
+ toTheme: number;
+ script?: string;
+ session: AdminSession;
+}
+export declare function upgradeTheme(upgradeOptions: UpgradeThemeOptions): Promise<Theme | undefined>;
+export declare function updateTheme(id: number, params: ThemeParams, session: AdminSession): Promise<Theme | undefined>;
+export declare function publishTheme(id: number, session: AdminSession): Promise<Theme | undefined>;
+export declare function deleteTheme(id: number, session: AdminSession): Promise<Theme | undefined>;
+export {};
\ No newline at end of file
packages/cli-kit/dist/public/node/themes/types.d.ts@@ -28,7 +28,6 @@ export interface ThemeFileSystemOptions {
only?: string[];
};
notify?: string;
- noDelete?: boolean;
}
/**
* Represents a theme on the file system.
packages/cli-kit/dist/public/node/themes/utils.d.ts@@ -4,6 +4,4 @@ export declare const LIVE_THEME_ROLE = "live";
export declare const UNPUBLISHED_THEME_ROLE = "unpublished";
export type Role = typeof DEVELOPMENT_THEME_ROLE | typeof LIVE_THEME_ROLE | typeof UNPUBLISHED_THEME_ROLE;
export declare function isDevelopmentTheme(theme: Theme): boolean;
-export declare function promptThemeName(message: string): Promise<string>;
-export declare function composeThemeGid(id: number): string;
-export declare function parseGid(gid: string): number;
\ No newline at end of file
+export declare function promptThemeName(message: string): Promise<string>;
\ No newline at end of file
|
isaacroldan
approved these changes
Oct 30, 2024
Coverage report
Test suite run success1923 tests passing in 872 suites. Report generated by 🧪jest coverage report action from bb568c5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist