Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: update arm64 paths + v1.5.3 prepare #176

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

thepwagner
Copy link
Contributor

  • Run make gem locally.
  • Realize some paths have changed (or might have never worked :face-palm:), update them.
  • Don't use the --snapshot flag, as even when the current worktree is a clean tag it adds extra noise.
  • Do maintain VERSION, as this is what the gem build uses to version itself.

The underlying goal is to synchronize the version uploaded to rubygems with the version available on GitHub.

@thepwagner thepwagner requested a review from burke as a code owner November 4, 2024 19:37
@thepwagner thepwagner self-assigned this Nov 4, 2024
@thepwagner
Copy link
Contributor Author

$ git tag v1.5.3
$ make gem deb >/dev/null
$ file dist/ejson_1.5.3_linux_amd64.deb
dist/ejson_1.5.3_linux_amd64.deb: Debian binary package (format 2.0), with control.tar.gz, data compression gz

$ tar xvvf pkg/ejson-1.5.3.gem && tar xvvzf data.tar.gz
x -r--r--r--  0 wheel  wheel     556  4 Nov 14:39 metadata.gz
x -r--r--r--  0 wheel  wheel 7944365  4 Nov 14:39 data.tar.gz
x -r--r--r--  0 wheel  wheel     298  4 Nov 14:39 checksums.yaml.gz
x -rw-r--r--  0 wheel  wheel    1064  4 Nov 14:39 LICENSE.txt
x -rwxr-xr-x  0 wheel  wheel     486  4 Nov 14:39 bin/ejson
x -rwxr-xr-x  0 wheel  wheel 3923120  4 Nov 14:39 build/darwin-amd64/ejson
x -rwxr-xr-x  0 wheel  wheel 3862946  4 Nov 14:39 build/darwin-arm64/ejson
x -rwxr-xr-x  0 wheel  wheel 3813538  4 Nov 14:39 build/freebsd-amd64/ejson
x -rwxr-xr-x  0 wheel  wheel 3838104  4 Nov 14:39 build/linux-amd64/ejson
x -rwxr-xr-x  0 wheel  wheel 3735704  4 Nov 14:39 build/linux-arm64/ejson
x -rw-r--r--  0 wheel  wheel     697  4 Nov 14:39 ejson.gemspec
x -rw-r--r--  0 wheel  wheel      37  4 Nov 14:39 lib/ejson/version.rb

$ file build/*/ejson
build/darwin-amd64/ejson:  Mach-O 64-bit executable x86_64
build/darwin-arm64/ejson:  Mach-O 64-bit executable arm64
build/freebsd-amd64/ejson: ELF 64-bit LSB executable, x86-64, version 1 (FreeBSD), statically linked, for FreeBSD 12.3, FreeBSD-style, Go BuildID=kQuW6paitirv7GY4bem1/q_B2llMCDzE8HKDzlpBD/Gf75HS-6oiA8-hPyYU8G/qxuwjDJnWYUUgQnSxC-5, stripped
build/linux-amd64/ejson:   ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=18dFFrwf9uwIEajiaVrc/NRmPRZyEWyxBz3E0Enaa/GCsiz64jQmRwG3ubHFLT/htFy_VKaaQ3JoVHcgzOc, stripped
build/linux-arm64/ejson:   ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=vzoiGxEl254ZsRIAJ3MY/0xAbkw5dv2m06XsqKiYk/-zYuNoYMn-rMuXptut-5/8wNagUDo7kQ1dXtktd_F, stripped

$ build/darwin-arm64/ejson --version
ejson version 1.5.3

@thepwagner thepwagner requested review from a team and PeteMango and removed request for a team November 6, 2024 14:04
Copy link

@PeteMango PeteMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@thepwagner thepwagner merged commit 858fad8 into main Nov 6, 2024
2 checks passed
@thepwagner thepwagner deleted the fix-gem-build branch November 6, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants