add forward slash to escape character

Shopify · Sep 15, 2015 · fa28233 · fa28233
1 parent f7394ad
commit fa28233
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/ext/json/ext/generator/generator.c b/ext/json/ext/generator/generator.c
@@ -171,6 +171,9 @@ static void convert_UTF8_to_JSON_ASCII(FBuffer *buffer, VALUE string)
                         case '\\':
                             fbuffer_append(buffer, "\\\\", 2);
                             break;
+                        case '/':
+                            fbuffer_append(buffer, "\\/", 2);
+                            break;
                         case '"':
                             fbuffer_append(buffer, "\\\"", 2);
                             break;
@@ -268,6 +271,10 @@ static void convert_UTF8_to_JSON(FBuffer *buffer, VALUE string)
                     escape = "\\\\";
                     escape_len = 2;
                     break;
+                case '/':
+                    escape = "\\/";
+                    escape_len = 2;
+                    break;
                 case '"':
                     escape =  "\\\"";
                     escape_len = 2;

diff --git a/java/src/json/ext/StringEncoder.java b/java/src/json/ext/StringEncoder.java
@@ -50,6 +50,7 @@ void encode(ByteList src, ByteList out) {
     private void handleChar(int c) {
         switch (c) {
         case '"':
+        case '/':
         case '\\':
             escapeChar((char)c);
             break;

diff --git a/lib/json/pure/generator.rb b/lib/json/pure/generator.rb
@@ -34,6 +34,7 @@ module JSON
     "\x1f" => '\u001f',
     '"'   =>  '\"',
     '\\'  =>  '\\\\',
+    '/'  =>  '\\/',
   } # :nodoc:
 
   # Convert a UTF8 encoded Ruby string _string_ to a JSON string, encoded with
@@ -42,15 +43,15 @@ module JSON
     def utf8_to_json(string) # :nodoc:
       string = string.dup
       string.force_encoding(::Encoding::ASCII_8BIT)
-      string.gsub!(/["\\\x0-\x1f]/) { MAP[$&] }
+      string.gsub!(/[\/"\\\x0-\x1f]/) { MAP[$&] }
       string.force_encoding(::Encoding::UTF_8)
       string
     end
 
     def utf8_to_json_ascii(string) # :nodoc:
       string = string.dup
       string.force_encoding(::Encoding::ASCII_8BIT)
-      string.gsub!(/["\\\x0-\x1f]/n) { MAP[$&] }
+      string.gsub!(/[\/"\\\x0-\x1f]/n) { MAP[$&] }
       string.gsub!(/(
                       (?:
                         [\xc2-\xdf][\x80-\xbf]    |
@@ -79,11 +80,11 @@ def valid_utf8?(string)
     module_function :valid_utf8?
   else
     def utf8_to_json(string) # :nodoc:
-      string.gsub(/["\\\x0-\x1f]/n) { MAP[$&] }
+      string.gsub(/[\/"\\\x0-\x1f]/n) { MAP[$&] }
     end
 
     def utf8_to_json_ascii(string) # :nodoc:
-      string = string.gsub(/["\\\x0-\x1f]/) { MAP[$&] }
+      string = string.gsub(/[\/"\\\x0-\x1f]/) { MAP[$&] }
       string.gsub!(/(
                       (?:
                         [\xc2-\xdf][\x80-\xbf]    |

diff --git a/tests/test_json.rb b/tests/test_json.rb
@@ -409,10 +409,10 @@ def test_backslash
     assert_equal json, JSON.generate(data)
     assert_equal data, JSON.parse(json)
     #
-    json = '["/"]'
-    data = JSON.parse(json)
-    assert_equal ['/'], data
+    data = [ '/' ]
+    json = '["\/"]'
     assert_equal json, JSON.generate(data)
+    assert_equal data, JSON.parse(json)
     #
     json = '["\""]'
     data = JSON.parse(json)