New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak for filters with keyword arguments #158

Closed

dylanahsmith wants to merge 1 commit into master from dts-kw-arg-mem-leak

Contributor

dylanahsmith commented Oct 12, 2021 •

edited

Loading

Alternative to #157 (see that PR for a description of the problem)
Closes #157

This differs from that PR in that it continues to eagerly free the memory to reduce garbage collection.

I tested with the script from #157 and it actually resulted in a lower RSS:

3 runs with this branch:
- 124832
- 124724
- 124924
on the Fix memory leak for filters with keyword arguments #157 branch
- 130264
- 131428
- 130488
on the master branch, for reference
- 204172


          Fix memory leak for filters with keyword arguments

75bc798

dylanahsmith requested a review from peterzhu2118

October 12, 2021 17:27

dylanahsmith mentioned this pull request

Fix memory leak for filters with keyword arguments #157

Merged

Contributor Author

dylanahsmith commented Oct 12, 2021

Closing in favour of #157, see the discussion there

dylanahsmith closed this

dylanahsmith deleted the dts-kw-arg-mem-leak branch

October 12, 2021 17:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet