Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error #58

Merged
merged 5 commits into from
Mar 23, 2020
Merged

Log error #58

merged 5 commits into from
Mar 23, 2020

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Mar 21, 2020 •
edited
Loading

What are you trying to accomplish with this PR?

Logs errors during watch

Fixes #40

Checklist

For contributors:

  • I have updated the documentation in the README file to reflect these changes, if applicable.

For maintainers:

  • I have 🎩'd these changes.
  • I have bumped the package.json version in a separate PR, if applicable.

erickzhao
erickzhao reviewed Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off the top of my head, won't this change reject the promise for tk.watch() as soon as an error is encountered rather than when the ThemeKit command finishes?

@wizardlyhel
Copy link
Contributor Author

You're right - thanks for catching that

@wizardlyhel wizardlyhel merged commit 3005d35 into master Mar 23, 2020
@wizardlyhel wizardlyhel deleted the log-error branch March 23, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme 'Watch' Not Returning Errors
2 participants
@wizardlyhel @erickzhao