Temporarily disable rb_str_concat, add CI tests (#407)

Make sure we can load the test-all runner and run test_yjit.rb
Shopify · Aug 16, 2022 · efeb5a8 · efeb5a8
1 parent c07a722
commit efeb5a8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.cirrus.yml b/.cirrus.yml
@@ -169,4 +169,7 @@ yjit_task:
   # Check that we can build rdoc successfully
   make_rdoc_script: source $HOME/.cargo/env && make -j rdoc
 
-  # TODO: check that we can we run test-all successfully
+  # Run John's YJIT instruction tests, and make sure we can load the test-all runner
+  test_yjit_script: source $HOME/.cargo/env && make test-all TESTS='test/ruby/test_yjit.rb' RUN_OPTS="--yjit-call-threshold=1"
+
+  # TODO: check that we can we run all of test-all successfully
diff --git a/.github/workflows/yjit-new-backend.yml b/.github/workflows/yjit-new-backend.yml
@@ -96,4 +96,7 @@ jobs:
       # Check that we can build rdoc successfully
       - run: make -j rdoc
 
-      # TODO: check that we can we run test-all successfully
+      # Run John's YJIT instruction tests, and make sure we can load the test-all runner
+      - run: make test-all TESTS='test/ruby/test_yjit.rb' RUN_OPTS="--yjit-call-threshold=1"
+
+      # TODO: check that we can we run all of test-all successfully
diff --git a/yjit/src/codegen.rs b/yjit/src/codegen.rs
@@ -6134,7 +6134,7 @@ impl CodegenGlobals {
             //self.yjit_reg_method(rb_cString, "to_s", jit_rb_str_to_s);
             //self.yjit_reg_method(rb_cString, "to_str", jit_rb_str_to_s);
             self.yjit_reg_method(rb_cString, "bytesize", jit_rb_str_bytesize);
-            self.yjit_reg_method(rb_cString, "<<", jit_rb_str_concat);
+            //self.yjit_reg_method(rb_cString, "<<", jit_rb_str_concat);
             //self.yjit_reg_method(rb_cString, "+@", jit_rb_str_uplus);
 
             // Thread.current