Invalidate memorized object http on host changes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
invalidate-cache-on-host-change
branch
from
087f8b7
to
86b0cc7
Compare
muz
approved these changes
Mar 14, 2022
Strech
reviewed
Mar 15, 2022
lib/toxiproxy.rb
Outdated
Comment on lines
71
to
74
| if defined? @http | ||
| @http.finish() if @http && @http.started? | ||
| @http = nil | ||
| end |
There was a problem hiding this comment.
I think we could extract it into some sort of method to reset all connections and it might be useful in the tests too
I throw some ideas (from more suitable to less)
reset_http_client!
# or
reset_http!
# or
reset_http_connections!There was a problem hiding this comment.
thank you! Now it looks cleaner ❤️
Currently http is cached and could be never changed. Make sure there is possible to update toxiproxy client to different server, invalidate cache for http.
miry
force-pushed
the
invalidate-cache-on-host-change
branch
from
86b0cc7
to
d6b911a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently http is cached and could be never changed.
Make sure there is possible to update toxiproxy client to different
server, invalidate cache for http.