Flask Server Integration for Nomic Game #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbrooks
reviewed
Apr 9, 2024
README.md
Outdated
| # stf-nomic-game | ||
| ## Setting Up a Python Virtual Environment |
There was a problem hiding this comment.
The environment instructions below are incorrect as we're using poetry so we should change accordingly
README.md
Outdated
| ``` | ||
|
|
||
| ## Integration of Nomic Game Logic into Flask App |
There was a problem hiding this comment.
These plans are pretty good. I'm not sure if they below in the readme though, maybe we should copy them and place them into the next ticket - #10
There was a problem hiding this comment.
I ended up copying these instructions into the ticket so we can just remove these
requirements.txt
Outdated
| @@ -0,0 +1 @@ | |||
| Flask==2.0.1 | |||
There was a problem hiding this comment.
I'm not sure if Poetry uses a requirements file so we should delete this one and replace with whatever poetry uses
snobbee
deleted the
taskforce_flask_server_integration_for_nomic_game_w2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdfor setting up a Python virtual environment.requirements.txtto manage project dependencies, including Flask version 2.0.1.app/__init__.pywith debug mode enabled.app/routes.py.README.mdwith instructions for running the Flask server locally and outlined a plan for future Nomic game logic integration.