Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): add baseline utility for integration testing from frontend ui #8765

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Nov 26, 2024

We want a way to automatically create and login to an account across the tests in a specific run

Changes 🏗️

  • Updates the creation and login pages/fixtures to store the user details in .auth/ folders
  • Adds SIMPLE profile tests
  • Finds bug in profile

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan -> Writing tests!

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/l labels Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit f4a44c8
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6745531c32e1c40008442d0a
😎 Deploy Preview https://deploy-preview-8765--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit e9a6c82
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6746e65af9622c000821eb46

@ntindle ntindle marked this pull request as ready for review November 26, 2024 05:21
@ntindle ntindle requested a review from a team as a code owner November 26, 2024 05:21
@ntindle ntindle requested review from Torantulino and Bentlybro and removed request for a team November 26, 2024 05:21
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 Security concerns

Sensitive information exposure:
Test user credentials (email and password) are stored in plaintext files in the .auth/ directory. While these are test credentials, storing authentication data in plaintext files could pose a security risk if the repository is compromised. Consider encrypting the credentials or using environment variables for sensitive data.

⚡ Recommended focus areas for review

Performance Issue
Test uses a hardcoded 10 second wait and page reload to handle a known bug. This is a fragile solution that should be fixed properly by addressing the underlying issue.

Code Smell
Long timeout values of 60 seconds in waitForPageToLoad method could mask performance issues. Consider using shorter timeouts and better error handling.

Security Issue
Test user credentials are stored in plaintext in .auth/ directory. Consider encrypting sensitive test data or using environment variables.

@aarushik93
Copy link
Contributor

Finds bug in profile

what does this mean in changes?

@ntindle
Copy link
Member Author

ntindle commented Nov 26, 2024

Finds bug in profile

what does this mean in changes?

That I found a bug in the profile page

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit e9a6c82
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6746e65a2838c9000883159c

@ntindle ntindle enabled auto-merge (squash) November 27, 2024 09:28
@ntindle ntindle merged commit 5dd151b into dev Nov 27, 2024
19 checks passed
@ntindle ntindle deleted the ntindle/open-2060-add-a-utility-that-enables-all-tests-other-than-auth-to-use branch November 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 3 size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants