Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Fix missing credentials input when no credentials available #8834

Merged
merged 5 commits into from
Nov 27, 2024
Merged

fix(frontend): Fix missing credentials input when no credentials available #8834

merged 5 commits into from
Nov 27, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 27, 2024 •
edited
Loading

Changes 🏗️

  • Build CredentialsProvider output object from CREDENTIALS_PROVIDER_NAMES instead of just the available credentials

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Create a block for which no credentials are available. The block should have a visible Credentials input.

@Pwuts Pwuts requested a review from a team as a code owner November 27, 2024 15:57
@Pwuts Pwuts requested review from Bentlybro and kcze and removed request for a team November 27, 2024 15:57
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Nov 27, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 03771f2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/674750226999d10008b88087

@Pwuts Pwuts enabled auto-merge (squash) November 27, 2024 15:58
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 03771f2
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67475022b3cf2a0008af2b55

@Pwuts Pwuts requested review from aarushik93 and removed request for Bentlybro November 27, 2024 16:00
@Pwuts Pwuts disabled auto-merge November 27, 2024 17:33
@Pwuts Pwuts added this pull request to the merge queue Nov 27, 2024
@Pwuts Pwuts removed this pull request from the merge queue due to a manual request Nov 27, 2024
@Pwuts Pwuts added this pull request to the merge queue Nov 27, 2024
@Pwuts Pwuts removed this pull request from the merge queue due to a manual request Nov 27, 2024
@Pwuts Pwuts added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@Pwuts Pwuts added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@Pwuts Pwuts added this pull request to the merge queue Nov 27, 2024
Merged via the queue into dev with commit d2f3f53 Nov 27, 2024
19 checks passed
@Pwuts Pwuts deleted the reinier/open-2131-fix-usecredentials-hook branch November 27, 2024 18:39
aarushik93 pushed a commit that referenced this pull request Dec 1, 2024
@Pwuts @ntindle @aarushik93
fix(frontend): Fix missing credentials input when no credentials avai…
de45f2b 
…lable (#8834)

Fixes breakage from f141455 (#8772)

Co-authored-by: Nicholas Tindle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntindle ntindle ntindle approved these changes

@kcze kcze Awaiting requested review from kcze kcze is a code owner automatically assigned from Significant-Gravitas/maintainers

@aarushik93 aarushik93 Awaiting requested review from aarushik93

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pwuts @ntindle