Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend) : Optional number input #8940

Conversation

Abhi1992002
Copy link
Contributor

Currently, the frontend renders a string input for an optional integer. I have now corrected it.

Screenshot 2024-12-11 at 10 23 48 AM

@Abhi1992002 Abhi1992002 requested a review from a team as a code owner December 11, 2024 04:55
@Abhi1992002 Abhi1992002 requested review from Swiftyos and Bentlybro and removed request for a team December 11, 2024 04:55
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Dec 11, 2024
@Abhi1992002 Abhi1992002 changed the title fix optional number input fix(frontend) : optional number input Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 8a5b31d
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/67591b5b49650f0008021eb7

@Abhi1992002 Abhi1992002 changed the title fix(frontend) : optional number input fix(frontend) : Optional number input Dec 11, 2024
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 8a5b31d
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67591b5b70adfe000882a711
😎 Deploy Preview https://deploy-preview-8940--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Abhi1992002
Copy link
Contributor Author

I think we also need to render other optional types also.

Copy link
Member

@Bentlybro Bentlybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, Thank you :)

@ntindle ntindle added this pull request to the merge queue Dec 11, 2024
Merged via the queue into Significant-Gravitas:dev with commit b8a3ffc Dec 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants