Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete for custom registered macros #3292

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Add autocomplete for custom registered macros #3292

merged 2 commits into from
Jan 12, 2025

Conversation

Cohee1207
Copy link
Member

Also allow descriptions for them.

Checklist:

@Cohee1207 Cohee1207 added 🟩 PR - Small <100 lines changed 👷 Maintainer [ISSUE][PR] Posts by a maintainer or author of SillyTavern 🌟 UX [PR][ISSUE] Directly relates to User Experience 🧩 Macros [PR][ISSUE] Related to Macros and the Macro Engine labels Jan 11, 2025
@Cohee1207 Cohee1207 requested a review from Wolfsblvt January 11, 2025 21:27
Wolfsblvt
Wolfsblvt approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@Wolfsblvt Wolfsblvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as described. Makes sense to have descriptions - besides the ones you could hack into the macros html description.

@Cohee1207 Cohee1207 merged commit 40d29bd into staging Jan 12, 2025
6 checks passed
@Cohee1207 Cohee1207 deleted the macrosparser branch January 12, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wolfsblvt Wolfsblvt Wolfsblvt approved these changes

Assignees
No one assigned
Labels
🧩 Macros [PR][ISSUE] Related to Macros and the Macro Engine 👷 Maintainer [ISSUE][PR] Posts by a maintainer or author of SillyTavern 🟩 PR - Small <100 lines changed 🌟 UX [PR][ISSUE] Directly relates to User Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cohee1207 @Wolfsblvt