Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Prome spanish translation #3293

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

Bronya-Rand
Copy link
Contributor

Since someone added Traditional Chinese translations to Prome for ST, might as well do the same for Spanish.

Checklist:

Since someone added Traditional Chinese translations to Prome for ST, might as well do the same for Spanish.
Copy link
Collaborator

@Wolfsblvt Wolfsblvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if you keep the same indentation style on the files than they had before - which means 4 spaces for translation files.

Otherwise it's really hard to see the actual changes.

@Wolfsblvt Wolfsblvt added the 🌐 Language [PR] Adds or modifies language translations or features label Jan 12, 2025
@Bronya-Rand Bronya-Rand requested a review from Wolfsblvt January 12, 2025 03:52
@Bronya-Rand
Copy link
Contributor Author

Apologies. Due to working on PygSite with Biome, my formatter (Biome) decided to basically format all the contents of the translation file to be tabs than spaces.

@Wolfsblvt Wolfsblvt added the 🟨 PR - Medium 100-500 lines changed label Jan 12, 2025
Copy link
Collaborator

@Wolfsblvt Wolfsblvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand Spanish, but I trust your translation skills.

Good now.

@Wolfsblvt Wolfsblvt merged commit 6ab79ae into SillyTavern:staging Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 Language [PR] Adds or modifies language translations or features 🟨 PR - Medium 100-500 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants