feat: add support for v8 version 10+ #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from Node 16 to Node 18 I noticed that I get some
undefined
s in thegctype
label in my prometheus metrics:After digging into this a bit, I found out that the
GCType
enum was changed in v8 in version 10 in this PR (checkdeps/v8/include/v8-callbacks.h
):Before:
https://github.com/nodejs/node/blob/554fa24916c5c6d052b51c5cee9556b76489b3f7/deps/v8/include/v8.h#L6137-L6144
After:
https://github.com/nodejs/node/blob/main/deps/v8/include/v8-callbacks.h#L150-L159
I made some changes to be able to support both 10+ and <10 versions of v8 with proper GC type mappings.
Let me know what you think.