Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CommandBus and EventBus classes to support Symfony Autowiring #52

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Add CommandBus and EventBus classes to support Symfony Autowiring #52

merged 1 commit into from
Oct 30, 2017

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 2, 2017

@ruudk ruudk mentioned this pull request Oct 2, 2017
Merged
@ruudk
Copy link
Contributor Author

ruudk commented Oct 16, 2017

@cmodijk WDYT?

@cmodijk cmodijk merged commit e46f51e into SimpleBus:master Oct 30, 2017
@cmodijk
Copy link
Member

cmodijk commented Oct 30, 2017

@ruudk Thanks!

@cmodijk
Copy link
Member

cmodijk commented Oct 30, 2017

@ruudk We should also write some docs about this new feature can you create that?

@ruudk ruudk mentioned this pull request Oct 30, 2017
Merged
@ruudk ruudk deleted the facade branch November 1, 2017 16:20
@ruudk
Copy link
Contributor Author

ruudk commented Nov 1, 2017

@cmodijk I was thinking about creating a new release (after #53 is merged). But when I looked at the diff I was wondering if this PR was some kind of BC break? Since it changes the class of the service. The implementation extends from the original class, so I guess we are fine, right?

@cmodijk
Copy link
Member

cmodijk commented Nov 6, 2017

I think we are fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruudk @cmodijk