Performance improvements and refactoring #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce code duplication and reduce unnecessary computions.
Cache matrices and use Transform2D * PackedVector2Array multiplication where applicable.
It's the same as in shape_base.
Depending on shape size, this function alone takes up to 1ms! It was called for every tesselated point. By only calling this function once we can reduce generation time by 30-40%. It's not a real fix, but it's a workaround for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of patches that try to improve the performance and reduce some code duplication.
546645a alone reduces overall generation time by 30-40%. See also #119.
There is still a lot more to optimize, but it's a start.
Depending on the state of #118, I can rebase my branch on @narren96c's branch.
All tests pass of course.