-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextjs-xmcloud][sitecore-jss-nextjs] Component Library endpoint #1987
Open
art-alexeyenko
wants to merge
20
commits into
dev
Choose a base branch
from
feature/jss-4556-render-component
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR is missing a part with component update listener |
stasmaxymov
reviewed
Dec 2, 2024
packages/sitecore-jss-nextjs/src/components/ComponentLibraryLayout.tsx
Outdated
Show resolved
Hide resolved
art-alexeyenko
added
do-not-merge
and removed
do-not-review
PR's not ready for review
labels
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Extends api/editing/render endpoint with Component Library functionality - so that a single component can be rendered and experimented with.
The implementation has two main parts:
component:ready
event and handles component updates fromcomponent:update
event.Some parts of the logic are prepared to be reused for other frameworks.
Please don't merge until release prep for 22.3 begins.
Testing Details
Types of changes