Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the AutoOrientWebProcessor. #220

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

dlemstra
Copy link
Member

@dlemstra dlemstra commented Feb 6, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This pull request remove the AutoOrientWebProcessor since I suspect that most poeple will use this together with resizing. This is new and has not yet been released so we can still remove it at this point. And incase someone really needs this they can copy the code from this PR.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #220 (11c6ef6) into master (d3a834f) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #220   +/-   ##
=====================================
- Coverage      87%    87%   -1%     
=====================================
  Files          71     70    -1     
  Lines        1831   1824    -7     
  Branches      269    268    -1     
=====================================
- Hits         1597   1589    -8     
- Misses        165    166    +1     
  Partials       69     69           
Flag Coverage Δ
unittests 87% <100%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...DependencyInjection/ServiceCollectionExtensions.cs 100% <100%> (ø)
...ching/LruCache/ConcurrentTLruCache{TKey,TValue}.cs 54% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a834f...11c6ef6. Read the comment docs.

@JimBobSquarePants
Copy link
Member

Yep. I considered doing this and held back. I don't think we need it in the repo.

@JimBobSquarePants JimBobSquarePants added this to the v2.0.0 milestone Feb 6, 2022
@JimBobSquarePants JimBobSquarePants merged commit 9a03ec8 into master Feb 6, 2022
@JimBobSquarePants JimBobSquarePants deleted the dl/remove-auto-orient-web-processor branch February 6, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants