Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AuthenticationRegion to AmazonS3Client Endpoint based clients #263

Conversation

mdupras
Copy link
Contributor

@mdupras mdupras commented May 10, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Simply adding the optional AuthenticationRegion property to the AmazonS3Config.

#262

@CLAassistant
Copy link

CLAassistant commented May 10, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #263 (f8f5047) into main (b1c5e2f) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #263   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        75     75           
  Lines      2036   2036           
  Branches    298    298           
===================================
+ Hits       1739   1741    +2     
+ Misses      213    211    -2     
  Partials     84     84           
Flag Coverage Δ
unittests 85% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...geSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs 18% <100%> (ø)
.../Synchronization/RefCountedConcurrentDictionary.cs 76% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c5e2f...f8f5047. Read the comment docs.

@JimBobSquarePants JimBobSquarePants modified the milestones: v2.0.0, v2.0.1 May 18, 2022
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@JimBobSquarePants JimBobSquarePants merged commit 607c6a9 into SixLabors:main May 18, 2022
@mdupras mdupras deleted the hotfix/mdupras/262-s3-endpoint-region branch March 15, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants