-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build status shield #294
Fixed build status shield #294
Conversation
This is fantastic, I was blissfully unaware of badges/shields#8671 Would it be possible for you to do the same for some of the other repositories? It would be really useful if you could. |
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
===================================
Coverage 85% 85%
===================================
Files 76 76
Lines 2173 2173
Branches 304 304
===================================
Hits 1859 1859
Misses 229 229
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Haha I could dedicate more time if you would consider accepting a PR making use of https://github.com/MarkCiliaVincenti/AsyncKeyedLock (available on NuGet as a library) as a replacement for the keyed locker you currently use :) |
Aha! We actually use a vastly different approach to the one described in the original SO question many moons ago. The system is now lock free https://github.com/SixLabors/ImageSharp.Web/pull/124 This has been heavily tested and benchmarked. |
I will run some benchmarks against mine later :) |
|
Fixed an issue with the build status shield in README.md