Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AccessViolationException and hard crash with animated webp #2676

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Fix AccessViolationException and hard crash with animated webp #2676

merged 5 commits into from
Feb 26, 2024

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Feb 26, 2024 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates our sanitation checks to ensure there is no possibilty of underflow whe width < 9.
Fixes #2670

@JimBobSquarePants JimBobSquarePants changed the base branch from main to release/3.1.x February 26, 2024 02:01
@JimBobSquarePants JimBobSquarePants linked an issue Feb 26, 2024 that may be closed by this pull request
AccessViolationException and hard crash with animated webp #2670
Closed
4 tasks
@JimBobSquarePants JimBobSquarePants merged commit 0cbf475 into release/3.1.x Feb 26, 2024
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-2670 branch February 26, 2024 23:19
@JimBobSquarePants JimBobSquarePants mentioned this pull request Feb 27, 2024
Merged
4 tasks
@JimBobSquarePants JimBobSquarePants mentioned this pull request Mar 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfoidl gfoidl gfoidl left review comments

@brianpopow brianpopow brianpopow approved these changes

Assignees
No one assigned
Labels
bug formats:webp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AccessViolationException and hard crash with animated webp
3 participants
@JimBobSquarePants @gfoidl @brianpopow