[WIP] Add NoRedundantInlineAnnotationsRule

lib/NoUselessInlineAnnotationsRule.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SlamPhpStan;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\Assign;
+use PHPStan\Analyser\Scope;
+use PHPStan\Broker\Broker;
+use PHPStan\Rules\Rule;
+
+final class NoUselessInlineAnnotationsRule implements Rule
+{
+    /**
+     * @var Broker
+     */
+    private $broker;
+
+    public function __construct(Broker $broker)
+    {
+        $this->broker = $broker;
+    }
+
+    public function getNodeType(): string
+    {
+        return Assign::class;
+    }
+
+    /**
+     * @param \PhpParser\Node\Expr\Assign $node
+     * @param \PHPStan\Analyser\Scope     $scope
+     *
+     * @return string[] errors
+     */
+    public function processNode(Node $node, Scope $scope): array
+    {
+        r($node);
+    }
+}

tests/NoUselessInlineAnnotationsRuleTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SlamPhpStan\Tests;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use SlamPhpStan\NoUselessInlineAnnotationsRule;
+
+/**
+ * @covers \SlamPhpStan\NoUselessInlineAnnotationsRule
+ */
+final class NoUselessInlineAnnotationsRuleTest extends RuleTestCase
+{
+    protected function getRule(): Rule
+    {
+        $broker = $this->createBroker();
+
+        return new NoUselessInlineAnnotationsRule($broker);
+    }
+
+    public function testClassConstant()
+    {
+        $this->analyse(
+            [
+                __DIR__ . '/TestAsset/NoUselessInlineAnnotationsRule/fixture.php',
+            ],
+            [
+                [
+                    'Function mkdir is unsafe to use, rely on Symfony component Filesystem::mkdir instead.',
+                    9,
+                ],
+                [
+                    'Function readlink is unsafe to use, rely on Symfony component Filesystem::readlink instead.',
+                    12,
+                ],
+                [
+                    'Function touch is unsafe to use, rely on Symfony component Filesystem::touch instead.',
+                    15,
+                ],
+            ]
+        );
+    }
+}

tests/TestAsset/NoUselessInlineAnnotationsRule/fixture.php

@@ -0,0 +1,77 @@
+<?php
+
+namespace SlamPhpStan\Tests\TestAsset\NoUselessInlineAnnotationsRule;
+
+class Foo {
+    public function tester()
+    {
+        /** @var Bar[] $foo1 */
+        $foo1 = $this->bar1();
+
+        /** @var Bar $foo2 */
+        $foo2 = $this->bar2();
+
+        /** @var Bar $foo2bis */
+        $foo2bis = $this->bar2bis();
+
+        /** @var Bar[] $foo3 */
+        $foo3 = $this->bar3();
+
+        /** @var Bar $foo4 */
+        $foo4 = $this->bar4();
+
+        $no = $this->bar1();
+        $no = $this->bar2();
+        $no = $this->bar2bis();
+        $no = $this->bar3();
+        $no = $this->bar4();
+
+        /** @var Bar[] $xyz */
+        $foo1 = $this->bar1();
+
+        /** @var Bar $xyz */
+        $foo2 = $this->bar2();
+
+        /** @var Bar $xyz */
+        $foo2bis = $this->bar2bis();
+
+        /** @var Bar[] $xyz */
+        $foo3 = $this->bar3();
+
+        /** @var Bar $xyz */
+        $foo4 = $this->bar4();
+    }
+
+    /**
+     * @return Bar[]
+     */
+    public function bar1(): array
+    {
+        return [new Bar()];
+    }
+
+    public function bar2(): Bar
+    {
+        return new Bar();
+    }
+
+    /**
+     * @return Bar
+     */
+    public function bar2bis()
+    {
+        return new Bar();
+    }
+
+    public function bar3(): array
+    {
+        return [new Bar()];
+    }
+
+    public function bar4()
+    {
+        return new Bar();
+    }
+}
+
+class Bar {}