Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Interop and PSR containers for $container->get() resolution #28

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Support Interop and PSR containers for $container->get() resolution #28

merged 3 commits into from
Sep 22, 2021

Conversation

InvisibleSmiley
Copy link
Contributor

  • README.md renumbering happened automatically. Can revert if necessary.
  • composer.json rewrite happened automatically. Cannot easily revert (triggered by dev dependency malukenho/mcbumpface).

@InvisibleSmiley
Copy link
Contributor Author

This is for issue 27. No idea how to link it.

@Slamdunk Slamdunk linked an issue Sep 16, 2021 that may be closed by this pull request
@Slamdunk Slamdunk added the enhancement New feature or request label Sep 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #28 (996c93d) into master (f5c0da2) will decrease coverage by 0.53%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
- Coverage     46.37%   45.83%   -0.54%     
- Complexity       99      105       +6     
============================================
  Files            20       20              
  Lines           248      264      +16     
============================================
+ Hits            115      121       +6     
- Misses          133      143      +10     
Impacted Files Coverage Δ
...AbstractPluginMethodDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
...as/ServiceManagerGetDynamicReturnTypeExtension.php 0.00% <0.00%> (ø)
.../Rules/Laminas/ServiceManagerGetMethodCallRule.php 95.74% <88.88%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c0da2...996c93d. Read the comment docs.

@Slamdunk
Copy link
Owner

Awesome contribution, thank you, I'll take care of the CS failed build 👍

@Slamdunk Slamdunk merged commit d9243d9 into Slamdunk:master Sep 22, 2021
@Slamdunk
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support alternative container interfaces
3 participants